[PATCH] D112871: [lld/coff] Add parsing for /pdbpagesize: flag

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/COFF/Config.h:127
   llvm::SmallString<128> pdbAltPath;
+  int pdbPageSize = 4096;
   llvm::SmallString<128> pdbPath;
----------------
hans wrote:
> unsigned is probably more common LLVM-style (like ltoo or ltoPartitions), or maybe even size_t (like wordsize).
Given that this only stores a very limited set of small values, int has the advantage that writing 4096 instead of 4096u doesn't give you sign conversion warnings. So I (very weakly) prefer this here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112871/new/

https://reviews.llvm.org/D112871