[PATCH] D112895: [CVP] Canonicalize signed relational comparisons of scalar integers to unsigned comparison predicates

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:302
+  if (Cmp->getType()->isVectorTy() ||
+      !Cmp->getOperand(0)->getType()->isIntegerTy())
+    return false;
----------------
lebedev.ri wrote:
> nikic wrote:
> > Second condition is probably redundant, can't have anything else in a scalar icmp.
> While scalar icmp does produce i1 result, it may have pointer operands,
> and `LVI->getConstantRange()` asserts when that happens.
Oooh right, forgot about pointers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112895/new/

https://reviews.llvm.org/D112895