[PATCH] D90924: [ConstantRange] Sign-flipping of signedness-invariant comparisons

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/include/llvm/IR/ConstantRange.h:149
+  getEquivalentPredWithFlippedSignedness(CmpInst::Predicate Pred,
+                                         const ConstantRange &Other) const;
+
----------------
nikic wrote:
> I find it slightly odd that the other two are static methods but this one is an instance method -- any particular reason for that choice?
Nothing particular, but i think we are consistently inconsistent with this.
Let's go with `static`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90924/new/

https://reviews.llvm.org/D90924