[PATCH] D112312: [DSE] Add OR_None (not for commit)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 31 09:42:47 PDT 2021


fhahn abandoned this revision.
fhahn added a comment.

This is not really intended for commit, just to make it easy to apply/test the follow-up changes.

Let's work on getting the original D105098 <https://reviews.llvm.org/D105098> in.



================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1012
+      if (AAR == AliasResult::NoAlias)
+        return OW_None;
       return OW_Unknown;
----------------
nikic wrote:
> Maybe move this check to the start?
I originally had the check just after getting `AAR`, but `isOverwrite` considers out-of-bounds writes killing other writes to the same underlying object, which would be missed by the early exit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112312/new/

https://reviews.llvm.org/D112312



More information about the llvm-commits mailing list