[PATCH] D108741: [IR][GlobalDCE] Extend !vcall_visibility to be able to specify an offset range that it applies to

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 30 21:17:29 PDT 2021


kubamracek added a comment.

> I think Peter is saying that if you can make Clang emit correct ranges for v-tables — specifically so that the ranges don't cover the type_info pointer, which we don't emit enough metadata to safely remove — then you can also go ahead and remove the special case where we only eliminate loads of function pointers. That's assuming we don't need to support old bitcode.

Makes sense, thanks for the explanation. @pcc, just to make sure I'm on the same page as you -- this special casing of Functions is already there in GlobalDCE today, correct? The patch as is right now is not adding a new restriction, or regressing the existing behavior, correct?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108741/new/

https://reviews.llvm.org/D108741



More information about the llvm-commits mailing list