[PATCH] D112879: [MachO] Use error instead of fatal for missing -arch

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai created this revision.
smeenai added a reviewer: lld-macho.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
smeenai requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

`fatal` should only be used for malformed inputs according to
ErrorHandler.h; `error` is more appropriate for missing arguments,
accompanied by a check to bail out early in case of the error. Some
tests need to be adjusted accordingly.

Makes `lld/test/MachO/arch.s` pass with `LLD_IN_TEST=2`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112879

Files:
  lld/MachO/Driver.cpp
  lld/test/MachO/color-diagnostics.test
  lld/test/MachO/driver.test
  lld/test/MachO/search-paths-darwin.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112879.383628.patch
Type: text/x-patch
Size: 4097 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211030/1ab3e180/attachment.bin>