[PATCH] D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 30 16:22:24 PDT 2021


hvdijk added a comment.

It's worse. While trying to patch NetworkManager to add __attribute__((__retain__)), I found that __has_attribute(__retain__) is effectively broken in GCC, which you already knew about: you reported it to GCC (bug 99587). The switch really should have been left alone until that was fixed first: flipping the switch has left us in a state where code is broken and needs modification to work, but the way we should modify the code for clang, the way we generally recommend in documentation, breaks the code for GCC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96914/new/

https://reviews.llvm.org/D96914



More information about the llvm-commits mailing list