[PATCH] D112820: Emit hidden hostcall argument for sanitized kernels.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:825
+    else if (M->getModuleFlag("amdgpu_hostcall") ||
+        //Emit hidden_hostcall_buffer argument for address sanitized functions
+        //since they use hostcall buffer to report invalid memory access.
----------------
Space after //


================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadate-hostcall-present-v3-asan.ll:1-2
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 --amdhsa-code-object-version=3 -filetype=obj -o - < %s | llvm-readelf --notes - | FileCheck %s
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 --amdhsa-code-object-version=3 -amdgpu-dump-hsa-metadata -amdgpu-verify-hsa-metadata -filetype=obj -o - < %s 2>&1 | FileCheck --check-prefix=PARSER %s
+
----------------
You can do this with a single llc invocation.

Also typo "metadate" in the filename


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112820/new/

https://reviews.llvm.org/D112820