[PATCH] D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output.
Steven Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 29 12:27:19 PDT 2021
steven_wu added inline comments.
================
Comment at: llvm/lib/Support/raw_ostream.cpp:918
+ sys::fs::file_status Status;
+ EC = status(get_fd(), Status);
+ if (EC || Status.type() != sys::fs::file_type::regular_file)
----------------
Would it be better to cache the result in the constructor for raw_fd_ostream? Adding another `status` call might not be optimal.
@dexonsmith Do you have any concerns over this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112297/new/
https://reviews.llvm.org/D112297
More information about the llvm-commits
mailing list