[PATCH] D112733: [AMDGPU] Fix cvt_f32_ubyte combine with shl

Fri Oct 29 12:18:54 PDT 2021

vangthao added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/cvt_f32_ubyte.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=amdgcn-- -mcpu=tahiti -verify-machineinstrs < %s | FileCheck %s -check-prefixes=GCN,SI
----------------
foad wrote:
> This comment is misleading now because you didn't generate all the GFX9 checks for your new RUN line, and you didn't generate checks for the new function cvt_f32_ubyte0_vector.
Removed comment in D112839

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112733/new/

https://reviews.llvm.org/D112733