[PATCH] D112040: [InlineAdvisor] Add fallback/format switches and negative remark processing to Replay Inliner

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin accepted this revision.
mtrofin added a comment.

lgtm



================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:877
 
-      auto Advice = Advisor.getAdvice(*CB, OnlyMandatory);
+      std::unique_ptr<InlineAdvice> Advice =
+          Advisor.getAdvice(*CB, OnlyMandatory);
----------------
modimo wrote:
> mtrofin wrote:
> > unrelated change?
> The comment below is that `!Advice` isn't very clear with auto and also tripped me up: the previous change
> `if (!Advice || !Advice->isInliningRecommended()) {`
> 
> treated `!Advice` as having "negative" advice rather than being empty. Clearing this up seems valuable.
ah, good point, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112040/new/

https://reviews.llvm.org/D112040