[PATCH] D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs

Fri Oct 29 06:55:23 PDT 2021

chrisjackson marked an inline comment as done.
chrisjackson added inline comments.

================
Comment at: llvm/test/Transforms/LoopStrengthReduce/pr52161.ll:6-7
+
+; CHECK: scev-salvage: SCEV salvaging not possible. An IV could not be identified.
+; CHECK: scev-salvage: SCEV salvaging not possible. An IV could not be identified.
+
----------------
Orlando wrote:
> I wonder if the `-debug` output is necessary? As far as the IR output is concerned, we just want to see an undef dbg.value is generated but don't need to know how we arrived there. What do you think?
Agreed, I've removed the need for -debug

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111810/new/

https://reviews.llvm.org/D111810