[PATCH] D112754: X86: Fold masked merge pattern when and-not is not available

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 29 05:58:17 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:46387
+                                     TargetLowering::DAGCombinerInfo &DCI,
+                                     const X86Subtarget &Subtarget) const {
   SDValue N0 = N->getOperand(0);
----------------
you don't need to make this part of X86TargetLowering, you have access via:

const TargetLowering &TLI = DAG.getTargetLoweringInfo();


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:46481
+  if (!Subtarget.hasBMI() && VT.isScalarInteger() && VT != MVT::i1) {
+    if (SDValue R = foldMaskedMerge(N, DAG))
+      return R;
----------------
TLI.foldMaskedMerge(N, DAG)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112754/new/

https://reviews.llvm.org/D112754



More information about the llvm-commits mailing list