[PATCH] D111042: flang-omp-report summarising script

[Josh Mottley via Phabricator via llvm-commits]

josh.mottley.arm added inline comments.


================
Comment at: flang/examples/flang-omp-report-plugin/yaml_summarizer.py:69-80
+    Example after being processed to yaml:
+        /../llvm-project/flang/test/Examples/omp-device-constructs.f90:
+        - construct: target
+          line: 18
+          clauses:
+          - clause: map
+              details: arraya
----------------
awarzynski wrote:
> Wouldn't the output with `-l` only really differ when at least 2 input files were used?
The only difference when using 1 input file to original yaml file would be that the file path is stated only once at the top, whereas the original yaml file states the file with each construct.


================
Comment at: flang/examples/flang-omp-report-plugin/yaml_summarizer.py:118-135
+    Example after being processed to yaml:
+        - construct: target data
+          num: 1
+          clauses:
+          - clause: device
+              num: 1
+          - clause: map
----------------
awarzynski wrote:
> Was this generated using `/../llvm-project/flang/test/Examples/omp-device-constructs.f90`? (like for `process_log`?)
My bad. It was generated using all the omp tests. Changed example code to just use `/../llvm-project/flang/test/Examples/omp-device-constructs.yaml` now since its a bit more interesting as an example. Also made both "process" functions use the same ".yaml" file for the example, so you can see the clear difference between the two methods.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111042/new/

https://reviews.llvm.org/D111042