[PATCH] D112731: [AMDGPU] Really preserve LiveVariables in SILowerControlFlow

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveVariables.cpp:722
+  // Add new kill flags. For each block in which Reg is used but is not
+  // live-through, find the last instruction that uses Reg.
+  for (unsigned UseBBNum : UseBlocks) {
----------------
foad wrote:
> Does this work for phi uses? I'm not sure.
As explained in the comment on `struct VarInfo`, phi nodes should not be included in Kills, and I think that means that LiveVariables never sets the killed flag on phi use operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112731/new/

https://reviews.llvm.org/D112731