[PATCH] D112711: [fir] Add FIR CSE specific pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D112711#3095207 <https://reviews.llvm.org/D112711#3095207>, @mehdi_amini wrote:

>> This pass differs from the MLIR CSE pass in that it is FIR/Fortran semantics aware.
>
> Can you expand and provide details about this?
>
> (marking as "request changes" because @clementval told me to do so when discussing a revision, I haven't looked at the code at this point)

I updated the description about some information. This pass mainly use semantic information on `fir.call` and `fir.load` and optimized them out when possible. This is relying on the `pure` semantic for the calls. 
The optimization on `fir.load` will be prevented if they are flagged as `volatile` loads.

I think we should use "request changes" if there is any blocker change requested in the code. I guess this is also fair usage if you want to block this patch for discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112711/new/

https://reviews.llvm.org/D112711