[PATCH] D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

this is impossible for me to review especially since I don't really know html super well
but lgtm (with nits) I guess, I tried patching this in and running it and it does work as expected



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1309
+  using ChildIterator = std::unordered_set<DisplayNode *>::const_iterator;
+  // NOLINTNEXTLINE(readability-identifier-naming)
+  ChildIterator children_begin() const { return Children.cbegin(); }
----------------
I've barely seen this anywhere in LLVM, I don't think it's necessary


================
Comment at: llvm/test/Other/ChangePrinters/DotCfg/print-changed-dot-cfg.ll:133
+; CHECK-DOT-CFG-SIMPLE-NEXT: </div><br/>
+; CHECK-DOT-CFG-SIMPLE-NEXT:   <a>1. Pass VerifierPass on [module] omitted because no change</a><br/>
+; CHECK-DOT-CFG-SIMPLE-NEXT:   <a href="diff_2.pdf" target="_blank">2. Pass InstSimplifyPass on g</a><br/>
----------------
I'd add `-disable-verify` to the `opt` invocations to avoid these, since it'll already implicitly be off in a release build


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87202/new/

https://reviews.llvm.org/D87202