[PATCH] D112282: [llvm-profgen] Switch to DWARF-based symbol and ranges

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.h:190
+
+  std::set<std::string> FuncSymNames;
+
----------------
wlei wrote:
> wenlei wrote:
> > Would rellocate invalidate the StringRef holding the underlying strings? 
> Seems we all use this way to persist data for a reference type, like the context
> ` std::unordered_set<SampleContextFrameVector, SampleContextFrameHash> Contexts;`. I guess this should work.
std::unordered_map is not a volatile container, unlike std::vector. It's more like std::list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112282/new/

https://reviews.llvm.org/D112282