[PATCH] D112755: [docs] Expand a bit on the basics of a buildbot policy

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 28 13:53:57 PDT 2021


reames created this revision.
reames added reviewers: gkistanova, andreil99, fhahn, mehdi_amini.
Herald added subscribers: bollu, mcrosier.
reames requested review of this revision.
Herald added a project: LLVM.

We don't have much publicly documented about how build bots are maintained, and who has what responsibility with regards to the bots themselves and failures they report.

This change adds some basic framing on the topic.  It is intended to simplify document long standing practice, and to avoid introducing any new policy elements.  I do want to propose a couple of changes, but those will happen with their own review and broader discussion.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112755

Files:
  llvm/docs/HowToAddABuilder.rst


Index: llvm/docs/HowToAddABuilder.rst
===================================================================
--- llvm/docs/HowToAddABuilder.rst
+++ llvm/docs/HowToAddABuilder.rst
@@ -13,12 +13,41 @@
 
 There are two buildmasters running.
 
-* The main buildmaster at `<https://lab.llvm.org/buildbot>`_. All builders attached
-  to this machine will notify commit authors every time they break the build.
-* The staging buildbot at `<https://lab.llvm.org/staging>`_. All builders attached
-  to this machine will be completely silent by default when the build is broken.
-  Builders for experimental backends should generally be attached to this
-  buildmaster.
+* The main buildmaster at `<https://lab.llvm.org/buildbot>`_. All builders
+  attached to this machine will notify commit authors every time they break
+  the build.
+* The staging buildmaster at `<https://lab.llvm.org/staging>`_. All builders
+  attached to this machine will be completely silent by default when the build
+  is broken.
+
+In order to remain connected to the main buildmaster (and thus notify
+developers of failures), a builbot must:
+
+* Be building a supported configuration.  Builders for experimental backends
+  should generally be attached to staging buildmaster.
+* Be able to keep up with new commits to the main branch, or at a minimum
+  recover to tip of tree within a couple of days of falling behind.
+
+Additionally, we encourage all bot owners to point their bots towards the
+staging master during maintenance windows, instability troubleshooting, and
+such.
+
+Roles & Expectations
+====================
+
+Each buildbot has an owner who is the responsible party for addressing problems
+which arise with said buildbot.  We generally expect the bot owner to be
+reasonably responsive.
+
+For some bots, the ownership responsibility is split between a "resource owner"
+who provides the underlying machine resource, and a "configuration owner" who
+maintains the build configuration.  Generally, operational responsibility lies
+with the "config owner".  We do expect "resource owners" - who are generally
+the contact listed in a workers attributes - to proxy requests to the relevant
+"config owner" in a timely manner.
+
+Most issues with a buildbot should be addressed directly with a bot owner
+via email.  Please CC `Galina Kistanova <mailto:gkistanova at gmail.com>`_.
 
 Steps To Add Builder To LLVM Buildbot
 =====================================


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112755.383154.patch
Type: text/x-patch
Size: 2447 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211028/85b0a3b5/attachment.bin>


More information about the llvm-commits mailing list