[PATCH] D112731: [AMDGPU] Really preserve LiveVariables in SILowerControlFlow

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/LiveVariables.h:193
+  /// known to have a single def that dominates all uses. This can be useful
+  /// after removing some uses of \p Reg. It is not nocessary for the whole
+  /// machine function to be in SSA form.
----------------
Typo nocessary


================
Comment at: llvm/lib/CodeGen/LiveVariables.cpp:731-732
+      if (MI.readsRegister(Reg)) {
+        if (!MI.killsRegister(Reg)) {
+          MI.addRegisterKilled(Reg, nullptr);
+          VI.Kills.push_back(&MI);
----------------
Won't this do the right thing if you unconditionally call addRegisterKilled?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112731/new/

https://reviews.llvm.org/D112731