[PATCH] D112516: [SCEV][NFC] Factor out common API for getting unique operands of a SCEV

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I'm concerned that as-implemented this is could cause non-determinism in edge cases. SmallPtrSet has non-deterministic order, and I think the code in getDefiningScopeBound can be order dependent for cases where scopes with no dominance relation are involved (i.e. neither dominates the other). Do we need the "unique" aspect here? Ideally I'd just return an ArrayRef.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112516/new/

https://reviews.llvm.org/D112516