[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

[Victor Campos via Phabricator via llvm-commits]

vhscampos added inline comments.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
                                                  StringRef &Err) const {
-  llvm::AArch64::ParsedBranchProtection PBP;
-  if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+  llvm::ARM::ParsedBranchProtection PBP;
+  if (!llvm::ARM::parseBranchProtection(Spec, PBP, Err))
     return false;
----------------
aaron.ballman wrote:
> This change surprises me. Why should AArch64TargetInfo prefer calling into ARM instead?
Since that particular function ended up identical in both ARM and AArch64, we removed the AArch64 specific function and kept only one under ARM. You can spot the removal further down the patch.

The ARM namespace under ARMTargetParser.h already had code used in AArch64TargetParser, so we did not introduce new cross dependencies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112421/new/

https://reviews.llvm.org/D112421