[PATCH] D111285: Fix invalid Kill on callee save on RISC-V

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 28 05:44:53 PDT 2021


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: luke957.
This revision now requires review to proceed.

This looks good to me., thanks you! Very minor nits on the test file:

- I agree with Luis that modifying to use -march would be marginally better (you no longer need to worry if the datalayout string is the current standard RISC-V one for instance)
- Although a comment linking to this review thread doesn't make sense, it would probably be helpful to add a comment to note that the live X1 register isn't incorrectly marked as killed when being spilled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111285/new/

https://reviews.llvm.org/D111285



More information about the llvm-commits mailing list