[PATCH] D112617: [AArch64][SVE] Use TargetFrameIndex in more SVE load/store addressing modes

[Bradley Smith via Phabricator via llvm-commits]

bsmith added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:2246
-                    (RegImmInst (PTrue 31), GPR64sp:$base, simm4s1:$offset)>;
-    }
 
----------------
peterwaller-arm wrote:
> If these patterns are no longer needed, does the same thing apply to the two remaining uses of am_sve_fi?
> 
> https://github.com/llvm/llvm-project/blob/888af47095d5a7121c1d78566df59c292f30ceaf/llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td#L2304-L2305
> https://github.com/llvm/llvm-project/blob/888af47095d5a7121c1d78566df59c292f30ceaf/llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td#L2314-L2315
> 
> ... and if so could am_sve_fi be removed? I'm guessing here that these are no longer necessary because some other part of the lowering handles it after your change, and I see that STR_PXI and LDR_PXI are already handled around there.
Not in their current state, no. The Other uses of arm_sve_fi are in places that don't have patterns for that the indexed complex patterns that have changed. I did consider changing those instruction patterns, but it's not clear to me why they have been written like that, and given it's not causing an issue I opted to leave them as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112617/new/

https://reviews.llvm.org/D112617