[PATCH] D112696: CycleInfo: Introduce cycles as a generalization of loops

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/docs/CycleTerminology.rst:85
+
+2. If a node D dominates one or more nodes in a closed path P, then
+   there exists a cycle C that contains P but not D.
----------------
I think this needs to say "D **properly** dominates", with the usual convention that a block dominates itself but does not properly dominate itself. (We don't seem to have a domination terminology doc.)


================
Comment at: llvm/docs/CycleTerminology.rst:98
+3. If a closed path P contains nodes U1 and U2 but not their
+   dominators D1 and D2 respectively, then there exists a cycle C that
+   contains U1 and U2 but neither of D1 and D2.
----------------
"proper dominators"?


================
Comment at: llvm/docs/UserGuides.rst:30
    CoverageMappingFormat
+   CycleTerminology
    DebuggingJITedCode
----------------
Judging by the raw diff, you have introduced some Windows-style line endings into this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112696/new/

https://reviews.llvm.org/D112696