[PATCH] D112117: [llvm][LV] Drop poison-generating flags from FP instructions

Thu Oct 28 02:30:44 PDT 2021

dcaballe added a comment.

In D112117#3090902 <https://reviews.llvm.org/D112117#3090902>, @spatel wrote:

> I didn't go through all of the tests, but the first reduction expansion diff seems unintended to me (see inline comment). 
> We could enable dropping FMF only with an optional bool parameter? That would allow incremental updates. 
> Or we handle that as a one-off in the motivating LV caller?

Good catch! I like the optional bool parameter. Honestly, I don't feel very comfortable with dropping all the FMF flags by default since I don't understand in detail all the users of this utility. Let's go with that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112117/new/

https://reviews.llvm.org/D112117