[PATCH] D112607: [LNT] Refactored plot_parameters

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lnt/server/ui/views.py:851-852
+    except ValueError:
+        return abort(400,
+            "Invalid format of 'mean={}', expected mean=<machine id>.<field index>".format(value))
+
----------------



================
Comment at: lnt/server/ui/views.py:878-883
+    values = session.query(plot_parameter.field.column, ts.Order.llvm_project_revision,
+                           ts.Run.start_time, ts.Run.id) \
+                           .join(ts.Run).join(ts.Order) \
+                           .filter(ts.Run.machine_id == plot_parameter.machine.id) \
+                           .filter(ts.Sample.test == plot_parameter.test) \
+                           .filter(plot_parameter.field.column.isnot(None))
----------------
I think that's what flake8 wants, but do check by running tox.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112607/new/

https://reviews.llvm.org/D112607