[PATCH] D112690: MachineDominators: Define MachineDomTree type alias
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 28 02:20:22 PDT 2021
foad added a comment.
No objection to this patch, but the names are still pretty bad:
> DominatorTree / MachineDomTree is the class holding the dominator tree
> DominatorTreeWrapperPass / MachineDominatorTree is the corresponding (machine) function pass
It seems far too easy to confuse DominatorTree with MachineDominatorTree (only one is a pass) and MachineDomTree with MachineDominatorTree (which one is the pass?).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112690/new/
https://reviews.llvm.org/D112690
More information about the llvm-commits
mailing list