[PATCH] D112595: [IRSymTab] Mark __stack_chk_guard used

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D112595#3091582 <https://reviews.llvm.org/D112595#3091582>, @MaskRay wrote:

>> `__stack_chk_guard` is a user-defined variable
>
> Can be more accurate. For some architectures glibc define the variable (https://sourceware.org/bugzilla/show_bug.cgi?id=26817)

Yes, I've updated the summary.

>> There are a couple other symbols handled specially in Internalize.cpp (stack_chk_fail, and ssp_canary_word for AIX), should the all be handled uniformly?
>
> Echo this request. Would'be great to make the logic centralized, but may not be in this patch if you think not fit.

Hmm, I think the only place that needs this logic is IRSymTab; "RuntimeLibcalls.def" and Internalizer cover the rest of the use cases (ThinLTO, legacy LTO API).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112595/new/

https://reviews.llvm.org/D112595