[PATCH] D112684: [Internalize] Preserve __stack_chk_fail in Interalizer correctly

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 18:42:36 PDT 2021


ychen created this revision.
ychen added reviewers: MaskRay, tejohnson.
Herald added subscribers: ormris, steven_wu, hiraditya.
ychen requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Move the section collecting `AlwaysPreserved` up before any
`maybeInternalize` is called. Otherwise, functions (in this case, `__stack_chk_fail`)
are not preserved.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112684

Files:
  llvm/lib/Transforms/IPO/Internalize.cpp
  llvm/test/ThinLTO/X86/builtin-nostrip.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112684.382877.patch
Type: text/x-patch
Size: 4396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211028/e5f5187a/attachment.bin>


More information about the llvm-commits mailing list