[PATCH] D112489: [CSSPGO] Trim cold base profiles for the CS preinliner.

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 18:13:50 PDT 2021


wlei added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:357
   for (const auto &I : ColdProfiles) {
     if (MergeColdContext) {
       auto MergedContext = I.second->getContext().getContextFrames();
----------------
wlei wrote:
> `if(MergeColdContext && !TrimBaseProfileOnly)`
> 
> So that `MergedProfileMap` will be empty for `TrimBaseProfileOnly`
How about this comments? is `MergeColdContext ` always false when `TrimBaseProfileOnly` is true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112489/new/

https://reviews.llvm.org/D112489



More information about the llvm-commits mailing list