[PATCH] D112675: [Instcombine] Add patterns to generate fneg(fabs(x)) instead of fcmp/sub/selects (part 1)

Usman Nadeem via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 17:03:05 PDT 2021


mnadeem added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/fneg-fabs.ll:28
 ;
   %cmp = fcmp ult double %x, 0.000000e+00
   %negX = fsub double 0.000000e+00, %x
----------------
arsenm wrote:
> Missing some cases where the compared value is -0?
Any specific cases? Or should I duplicate all tests and set the compared value as `-0`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112675/new/

https://reviews.llvm.org/D112675



More information about the llvm-commits mailing list