[PATCH] D112594: [lld-macho] Implement -S

Vincent Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 16:11:47 PDT 2021


thevinster marked 2 inline comments as done.
thevinster added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:839-840
 void ObjFile::parseDebugInfo() {
+  if (config->omitDebugInfo)
+    return;
+
----------------
int3 wrote:
> When we implement https://bugs.llvm.org/show_bug.cgi?id=49282, we'll want to parse debug info regardless
Removed it. I added it originally to avoid the extra computation work if it's going to be skipped but performing this doesn't seem like a huge impact (plus the need to parse it down the road regardless)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112594/new/

https://reviews.llvm.org/D112594



More information about the llvm-commits mailing list