[PATCH] D112667: [lld][WebAssembly] Initialize bss segments using memory.fill

[Thomas Lively via Phabricator via llvm-commits]

tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

Code LGTM, thanks!



================
Comment at: lld/test/wasm/shared-memory-bss.s:61
+
+# Regular data gets initialized with memory.init
+
----------------
I think it would be clearer to place these comments before the arguments to the `memory.init` and `memory.fill` instructions rather than immediately before the instructions themselves. Also, it would be helpful if you could insert similar comments for the other parts of the code to split it into more easily digestible pieces. 


================
Comment at: lld/wasm/Writer.cpp:948
+    return false;
+  // Passive initilization of bss segments (via memory.fill) is required
+  // when memory is imported.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112667/new/

https://reviews.llvm.org/D112667