[PATCH] D111875: [Support] [Windows] Manually clean up temp files on network shares

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 14:22:39 PDT 2021


mstorsjo added a comment.

Just for the record for clarity, in D112376 <https://reviews.llvm.org/D112376> I considered an alternative approach, to remove the whole use of delete-on-close flags on Windows, to just use the `RemoveFileOnSignal` function instead. That has the much more visible drawback that temp files are left behind if processes are killed.

I'll go ahead and land this probably tomorrow, if there's nothing more to add here - it seems that this one doesn't have any objections now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111875/new/

https://reviews.llvm.org/D111875



More information about the llvm-commits mailing list