[PATCH] D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool

[Noah Shutty via Phabricator via llvm-commits]

noajshu marked 3 inline comments as done.
noajshu added inline comments.


================
Comment at: llvm/lib/Support/HTTPClient.cpp:77
+  if (Error Err = SizeOrErr.takeError()) {
+    errs() << Err << "\n";
+    return 0;
----------------
phosek wrote:
> Rather than printing the error to stderr which may be undesirable for example when using LLVM as a library, I think it'd be better to store the error inside the class (it might be possible to use `ErrorList`) and then return it from `curlPerform`.
Great idea, I've added this and removed the prints to stderr. The `ErrorState` will also surface for other `Error`-returning methods of `CurlHTTPRequest`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111252/new/

https://reviews.llvm.org/D111252