[PATCH] D112649: [libunwind] Simplify the executor used in the tests

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 12:06:18 PDT 2021


ldionne created this revision.
Herald added a project: libunwind.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libunwind.
ldionne requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Instead of going through libc++'s run.py, we can simply run the executable
directly since we don't need to setup a working directory or control the
environment.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112649

Files:
  libunwind/test/configs/llvm-libunwind-shared.cfg.in
  libunwind/test/configs/llvm-libunwind-static.cfg.in


Index: libunwind/test/configs/llvm-libunwind-static.cfg.in
===================================================================
--- libunwind/test/configs/llvm-libunwind-static.cfg.in
+++ libunwind/test/configs/llvm-libunwind-static.cfg.in
@@ -51,9 +51,7 @@
 config.substitutions.append(('%{link_flags}',
     '-nodefaultlibs {}/libunwind.a -ldl -lc {}'.format('@LIBUNWIND_LIBRARY_DIR@', ' '.join(link_flags))
 ))
-config.substitutions.append(('%{exec}',
-    '{} {}/utils/run.py --execdir %T -- '.format(sys.executable, '@LIBUNWIND_LIBCXX_PATH@')
-))
+config.substitutions.append(('%{exec}', ''))
 
 import os, site
 site.addsitedir(os.path.join('@LIBUNWIND_LIBCXX_PATH@', 'utils'))
Index: libunwind/test/configs/llvm-libunwind-shared.cfg.in
===================================================================
--- libunwind/test/configs/llvm-libunwind-shared.cfg.in
+++ libunwind/test/configs/llvm-libunwind-shared.cfg.in
@@ -49,9 +49,7 @@
 config.substitutions.append(('%{link_flags}',
     '-nodefaultlibs -L {0} -Wl,-rpath,{0} -lunwind -ldl -lc {1}'.format('@LIBUNWIND_LIBRARY_DIR@', ' '.join(link_flags))
 ))
-config.substitutions.append(('%{exec}',
-    '{} {}/utils/run.py --execdir %T -- '.format(sys.executable, '@LIBUNWIND_LIBCXX_PATH@')
-))
+config.substitutions.append(('%{exec}', ''))
 
 import os, site
 site.addsitedir(os.path.join('@LIBUNWIND_LIBCXX_PATH@', 'utils'))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112649.382748.patch
Type: text/x-patch
Size: 1383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211027/98832146/attachment.bin>


More information about the llvm-commits mailing list