[PATCH] D112589: [lld-macho] If export_size is zero, export_off must be zero

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 11:57:58 PDT 2021


int3 added a comment.

> optional : need tests for the case export_off is non-zero too?

I think that's sufficiently covered via our other tests. Actually I'd forgotten to run them when uploading the diff the first time around :) when I did I saw that my initial fix actually broke most of them... but that's addressed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112589/new/

https://reviews.llvm.org/D112589



More information about the llvm-commits mailing list