[PATCH] D112264: [ARC] Upstream the Synopsys out-of-tree load/store increment pass

[Graham Yiu via Phabricator via llvm-commits]

gyiu accepted this revision.
gyiu added a comment.
This revision is now accepted and ready to land.

Other than inline comments, LGTM.



================
Comment at: llvm/lib/Target/ARC/ARCOptAddrMode.cpp:470
+    if (baseOffsetSwapped) {
+      // P10019563-41714: avoid nonsense like "ldub %r0,[0,%1]"
+
----------------
Remove Jira number


================
Comment at: llvm/lib/Target/ARC/ARCOptAddrMode.cpp:567
+      ///////////////////////////////////////////////////
+      /// STAR 9001396843
+      /// Denis, please investigate:
----------------
Do we want to expose these comments to LLVM community?  Probably can remove STARs, Jiras, and release numbers.


================
Comment at: llvm/lib/Target/ARC/ARCOptAddrMode.cpp:1775
+
+  // P10019563-46423: keep track of vector candidates in inner loops. only
+  // permit a single vector candidate under -vdsp-inner-post-inc=single.
----------------
Jira number


================
Comment at: llvm/lib/Target/ARC/ARCUtil.h:23
+#if 0
+} fix emacs;
+#endif
----------------
Is this still valid?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112264/new/

https://reviews.llvm.org/D112264