[PATCH] D112303: [AArch64][SVE] Generate SVE >2 element structured load/stores from fixed types

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 08:36:15 PDT 2021


peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

Looks good to me. Optional nits.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12135
+                                               Intrinsic::aarch64_sve_ld4_sret};
+  static const Intrinsic::ID NeonLoadInts[3] = {Intrinsic::aarch64_neon_ld2,
+                                                Intrinsic::aarch64_neon_ld3,
----------------
nit. NEON? :)

trivial. While we're here I keep reading it as 'load integers', could we rename it to '...LoadIntrs'? Please reject this comment of mine unless you happen to agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112303/new/

https://reviews.llvm.org/D112303



More information about the llvm-commits mailing list