[PATCH] D110621: [llvm-locstats] Report a warning if overflow was detected by llvm-dwarfdump

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 06:22:59 PDT 2021


djtodoro added a comment.

In D110621#3090251 <https://reviews.llvm.org/D110621#3090251>, @thakis wrote:

> Also, given that we now unconditionally depend on llvm-locstats, should we remove `config.llvm_locstats_used` and delete `llvm/test/tools/llvm-locstats/lit.local.cfg`?

Oh, got it... it should actually go into its own directory...

> (Also, why is the tool in llvm/utils but the tests in llvm/test/tools?)

I am not sure if there was any test for the utilities from `llvm/utils`, so we decided to put the tests inside `llvm/test/tools` directory. Since this is more like a real tool, it may make sense to move the src code of the llvm-locstats inside `llvm/tools` (or even inside `llvm/tools/llvm-dwarfdump`). Please let me know what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110621/new/

https://reviews.llvm.org/D110621



More information about the llvm-commits mailing list