[PATCH] D112607: [LNT] Refactored plot_parameters

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 04:17:35 PDT 2021


thopre added a comment.

LGTM, but that patch introduces some flake8 regressions:

./lnt/server/ui/views.py:23:1: F401 <https://reviews.llvm.org/F401> 'typing.List' imported but unused
./lnt/server/ui/views.py:765:13: E128 continuation line under-indented for visual indent
./lnt/server/ui/views.py:765:88: E502 the backslash is redundant between brackets
./lnt/server/ui/views.py:766:13: E128 continuation line under-indented for visual indent
./lnt/server/ui/views.py:815:84: E502 the backslash is redundant between brackets
./lnt/server/ui/views.py:819:9: E303 too many blank lines (2)
./lnt/server/ui/views.py:838:1: W293 <https://reviews.llvm.org/W293> blank line contains whitespace
./lnt/server/ui/views.py:854:13: E128 continuation line under-indented for visual indent
./lnt/server/ui/views.py:881:23: E128 continuation line under-indented for visual indent
./lnt/server/ui/views.py:903:23: E128 continuation line under-indented for visual indent
./lnt/server/ui/views.py:904:23: E128 continuation line under-indented for visual indent
6     E128 continuation line under-indented for visual indent
1     E303 too many blank lines (2)
2     E502 the backslash is redundant between brackets
1     F401 <https://reviews.llvm.org/F401> 'typing.List' imported but unused
1     W293 <https://reviews.llvm.org/W293> blank line contains whitespace

Please fix those and run tox to check that it's happy.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112607/new/

https://reviews.llvm.org/D112607



More information about the llvm-commits mailing list