[PATCH] D112376: [Support] [Windows] Use the regular RemoveFileOnSignal() mechanism on Windows too

Wed Oct 27 03:01:11 PDT 2021

mstorsjo added a comment.

In D112376#3089544 <https://reviews.llvm.org/D112376#3089544>, @andrewevstyukhin wrote:

> Hi,
> in https://reviews.llvm.org/D81803 I showed that `is_local_internal` had no chances to execute because
>
>   if (std::error_code EC = realPathFromHandle(Handle, FinalPath))
>
> failed with error 40 (ERROR_INVALID_FUNCTION, **function_not_supported**). This happens at RAM-disk https://sourceforge.net/projects/imdisk-toolkit/.
> Currently emscripten versions 2.0.9+ couldn't pass tests at RAM-disk and versions 2.0.19+ couldn't even link anything when temporaries are at RAM-disk.

Hmm, I think this would work with D111875 <https://reviews.llvm.org/D111875> then, if I’d update it to remove the check for the specific error code on the return from `setDeleteDisposition`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112376/new/

https://reviews.llvm.org/D112376