[PATCH] D112187: [SelectionDAG] Add widen result function for insert subvector

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 27 02:40:27 PDT 2021


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM with nit addressed! Thanks @CarolineConcatto



================
Comment at: llvm/test/CodeGen/AArch64/sve-insert-vector.ll:428
+
+define <vscale x 3 x float> @insert_nxv3f32_nxv2f32(<vscale x 2 x float> %sv0) {
+; CHECK-LABEL: insert_nxv3f32_nxv2f32:
----------------
nit: please add `nounwind` attributes to the functions to avoid all the `.cfi` directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112187/new/

https://reviews.llvm.org/D112187



More information about the llvm-commits mailing list