[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

[Yueh-Ting Chen via Phabricator via llvm-commits]

eopXD added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:735
   const StringMap<std::vector<StringRef>> Implications = {
-    {"v", {"zvlsseg", "zvl128b"}},
+    {"v", {"zvlsseg", "zvl128b", "zve64d"}},
+
----------------
khchen wrote:
> please update implication rule based on https://github.com/riscv/riscv-v-spec/issues/723#issuecomment-949542444
> 1. The Zve32f and Zve64f extensions depend upon the F extension
> 2. The Zve64d extension depends upon the D extension
> 3. The V extension depends upon the F and D
Thanks for the reminder. Addressed.


================
Comment at: llvm/test/CodeGen/RISCV/attributes.ll:8
 ; RUN: llc -mtriple=riscv32 -mattr=+c %s -o - | FileCheck --check-prefix=RV32C %s
-; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+experimental-zvamo,+experimental-zvlsseg %s -o - | FileCheck --check-prefix=RV32V %s
+; RUN: llc -mtriple=riscv32 -mattr=+f,+d,+experimental-v,+experimental-zvamo,+experimental-zvlsseg %s -o - | FileCheck --check-prefix=RV32V %s
 ; RUN: llc -mtriple=riscv32 -mattr=+experimental-zfh %s -o - | FileCheck --check-prefix=RV32ZFH %s
----------------
frasercrmck wrote:
> Why is this being changed in this patch?
You are right. This should not be changed.

Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112408/new/

https://reviews.llvm.org/D112408