[PATCH] D111337: [fir] Add array value copy pass

Wed Oct 27 00:36:03 PDT 2021

clementval added a comment.

In D111337#3089322 <https://reviews.llvm.org/D111337#3089322>, @mehdi_amini wrote:

> I took a few minutes to evaluate more precisely the level of testing, see inline: we're very far from covering our bases here (and this is far from exhaustive!).
>
> I would suggest going back to first principles in terms of testing and building some solid and minimal tests for the passes you're trying to upstream.
> I know you're not necessarily the author of the passes, and I suggest to involve the author(s) of the code ahead of time to improve the testing before attempting to upstream all of this.

I agree with you that this test does not cover 100% of the pass. We have more extensive tests but they cannot be upstream right now since they are using another tool not upstreamed yet. This is the problem with upstreaming small chunk. Of course I'm trying to add tests where I can but this one can have some more. I'll rework on this patch and add more fir to fir tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111337/new/

https://reviews.llvm.org/D111337