[PATCH] D112518: [ELF] Change common diagnostics to report both object file location and source file location

Tue Oct 26 23:57:56 PDT 2021

MaskRay added inline comments.

================
Comment at: lld/test/ELF/ppc64-split-stack-adjust-overflow.s:23

-# OVERFLOW: error: {{.*}}.o:(function caller: .text+0x8): split-stack prologue adjustment overflows
+# OVERFLOW: error: {{.*}}.o:(.text+0x8): split-stack prologue adjustment overflows

----------------
peter.smith wrote:
> I note that we're missing the (function caller) before (.text+0x8). Same in next test. Is this intentional? Although this can be derived from looking at objdump/readelf it would be a shame to lose it. 
I restored the `function func: ` part. The change is reverted.

================
Comment at: lld/test/ELF/x86-64-reloc-error2.s:5

 ## Check we are able to find a function symbol that encloses
 ## a given location when reporting error messages.
----------------
peter.smith wrote:
> It looks like we are no longer reporting the function, only its section. I'm sure the references func is the target of the relocation. If we no longer output the information we should update the comment.
I restored the `function func: ` part. The change is reverted.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112518/new/

https://reviews.llvm.org/D112518