[PATCH] D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool

Noah Shutty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 21:01:53 PDT 2021


noajshu updated this revision to Diff 382517.
noajshu added a comment.

Workaround for unit tests, to avoid need for parent's destructor to invoke child's override.
There is a more general explanation of why this does not work here: more details here <https://wiki.sei.cmu.edu/confluence/display/cplusplus/OOP50-CPP.+Do+not+invoke+virtual+functions+from+constructors+or+destructors>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111252/new/

https://reviews.llvm.org/D111252

Files:
  llvm/CMakeLists.txt
  llvm/include/llvm/Debuginfod/Debuginfod.h
  llvm/include/llvm/Support/HTTPClient.h
  llvm/lib/CMakeLists.txt
  llvm/lib/Debuginfod/CMakeLists.txt
  llvm/lib/Debuginfod/Debuginfod.cpp
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/HTTPClient.cpp
  llvm/test/CMakeLists.txt
  llvm/test/lit.cfg.py
  llvm/test/lit.site.cfg.py.in
  llvm/test/tools/llvm-debuginfod/Inputs/buildid/fake_build_id/debuginfo
  llvm/test/tools/llvm-debuginfod/Inputs/buildid/fake_build_id/executable
  llvm/test/tools/llvm-debuginfod/Inputs/buildid/fake_build_id/source/directory/file.c
  llvm/test/tools/llvm-debuginfod/debuginfod-find.test
  llvm/tools/llvm-debuginfod/CMakeLists.txt
  llvm/tools/llvm-debuginfod/llvm-debuginfod-find.cpp
  llvm/unittests/CMakeLists.txt
  llvm/unittests/Debuginfod/CMakeLists.txt
  llvm/unittests/Debuginfod/DebuginfodTests.cpp
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/HTTPClient.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111252.382517.patch
Type: text/x-patch
Size: 37515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211027/53442440/attachment.bin>


More information about the llvm-commits mailing list