[PATCH] D112402: [SCEV][NFC] Verify intergity of SCEVUsers
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 26 19:55:28 PDT 2021
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5961f0308f5b: [SCEV][NFC] Verify intergity of SCEVUsers (authored by mkazantsev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112402/new/
https://reviews.llvm.org/D112402
Files:
llvm/lib/Analysis/ScalarEvolution.cpp
Index: llvm/lib/Analysis/ScalarEvolution.cpp
===================================================================
--- llvm/lib/Analysis/ScalarEvolution.cpp
+++ llvm/lib/Analysis/ScalarEvolution.cpp
@@ -12893,6 +12893,30 @@
assert(ValidLoops.contains(AR->getLoop()) &&
"AddRec references invalid loop");
}
+
+ // Verify intergity of SCEV users.
+ for (const auto &S : UniqueSCEVs) {
+ SmallPtrSet<const SCEV *, 4> Ops;
+ if (const auto *NS = dyn_cast<SCEVNAryExpr>(&S))
+ Ops.insert(NS->op_begin(), NS->op_end());
+ else if (const auto *CS = dyn_cast<SCEVCastExpr>(&S))
+ Ops.insert(CS->getOperand());
+ else if (const auto *DS = dyn_cast<SCEVUDivExpr>(&S)) {
+ Ops.insert(DS->getLHS());
+ Ops.insert(DS->getRHS());
+ }
+ for (const auto *Op : Ops) {
+ // We do not store dependencies of constants.
+ if (isa<SCEVConstant>(Op))
+ continue;
+ auto It = SCEVUsers.find(Op);
+ if (It != SCEVUsers.end() && It->second.count(&S))
+ continue;
+ dbgs() << "Use of operand " << *Op << " by user " << S
+ << " is not being tracked!\n";
+ std::abort();
+ }
+ }
}
bool ScalarEvolution::invalidate(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112402.382510.patch
Type: text/x-patch
Size: 1210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211027/0d5855ac/attachment.bin>
More information about the llvm-commits
mailing list