[PATCH] D112525: [LNT] Add more information to error messages

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lnt/server/ui/views.py:814-815
         except ValueError:
-            return abort(400)
+            return abort(400, "Parameter {} was malformed. {} must be int.int.int" \
+                              .format(name, value))
 
----------------
cmatthews wrote:
> thopre wrote:
> > slydiman wrote:
> > > kpdev42 wrote:
> > > > thopre wrote:
> > > > > Is it still the case, I remember a  patch that wanted to allow arbitrary strings
> > > > AFAIK, yes, URL is expected to contain something like ?plot.0=1.2.3 . If you can point to a patch, which allows arbitrary string, it would be useful and I'll change this part
> > > It is just a copy of the line 1716. The same is in the line 855.
> > I was thinking of https://reviews.llvm.org/D109577, I don't know if it's related to the value here.
> They are separate. This one is the data lookup used internally to resolve a particular data set; where as, the one int the review is the order format, which is used for x-axis and change-over-time calculations.
LGTM too then


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112525/new/

https://reviews.llvm.org/D112525